interactive rating component /js

Community feedback

• 

  Roberto Yukio Miyamoto Arita•320

  @RyukioMiyamotoPosted over 2 years ago

  Great job lukasz! I would just like to make two suggestions:

  • Final result is not matching 100% the proposed design, like font-size on the heading.
  • Although it was a very nice addition to prevent user from submiting without a rating, there's more elegant ways to do so than using alert(), like adding an <p> that only shows on submit, for example.

  There's also the matter of accessibility issues, which frontend mentor is pointing in your report:

  • Document should have one main landmark
  • All page content should be contained by landmarks

  Basically you can solve both by just changing your wrapper div to a <main> tag, which is of significant importance to screen readers. Hope you find this helpful! Good coding.

  Marked as helpful

  1

  ---

  

  Lukasz•160

  @lukaasz555Posted over 2 years ago

  @RyukioMiyamoto TY, appreciate it! That's my first public-shared code and every note and/or advice is priceless. I'll fix it as soon as possible!:)

  1

  

  Roberto Yukio Miyamoto Arita•320

  @RyukioMiyamotoPosted over 2 years ago

  @lukaasz555 off to a very good start!

  0