Interactive rating component | jQuery

Community feedback

• 

  SutonToch•340

  @SutonTochPosted over 1 year ago

  Looks great! Congrats on completing the challenge.

  I really like your comments and the way you space things out. Makes everything very readable.

  Your code looks absolutely fine to me and everything works like I would expect it. Some notes:

  • You declared CSS-variables but never used them. If you want to use your --lightGrey for example, replace #959eac outside :root with var(--lightGrey).
  • Your JS-variables should be const instead of let unless you reassign them. That way, it's more clear what is going to be reassigned at first glance.
  • You have a TypeError if someone tries to submit before choosing a rating. You can probably fix that with a simple conditional in your submitRating.click(...).

  If you have any further questions, feel free to throw them my way :).

  Be proud of yourself and keep on going!

  Marked as helpful

  0

  ---

  

  OsolalDev•70

  @OdaSolaDevPosted over 1 year ago

  Thank you for your notes! @SutonToch

  I made my code a little bit more clear with your tips, and I didn't even notice the TypeError. I fixed it and added a nice error message ^^. I will pay more attention to those from now on.

  0
• 

  Aravindhan•320

  @aravindhan7Posted over 1 year ago

  Hey, your solution was soo good, small corrections i want to tell.

  when the button is clicked, it should remain orange, but your solution shows grey when numbers are clicked.

  Morover if you hover numbers and submit button, the transition is soo fast. you can add timing to transition like

  transition: 0.3s (to look the hovers smooth)

  hope it is useful

  Marked as helpful

  0

  ---

  

  OsolalDev•70

  @OdaSolaDevPosted over 1 year ago

  Hi, @aravindhan7 !

  Thank you for your corrections. I made some changes with your tips, and now my solution looks better!

  0