@SutonToch
Posted
Looks great! Congrats on completing the challenge.
I really like your comments and the way you space things out. Makes everything very readable.
Your code looks absolutely fine to me and everything works like I would expect it. Some notes:
- You declared CSS-variables but never used them. If you want to use your
--lightGrey
for example, replace#959eac
outside:root
withvar(--lightGrey)
. - Your JS-variables should be
const
instead oflet
unless you reassign them. That way, it's more clear what is going to be reassigned at first glance. - You have a TypeError if someone tries to submit before choosing a rating. You can probably fix that with a simple conditional in your
submitRating.click(...)
.
If you have any further questions, feel free to throw them my way :).
Be proud of yourself and keep on going!
Marked as helpful
@OdaSolaDev
Posted
Thank you for your notes! @SutonToch
I made my code a little bit more clear with your tips, and I didn't even notice the TypeError. I fixed it and added a nice error message ^^. I will pay more attention to those from now on.