Interactive Rating Component | HTML/CSS | JAVASCRIPT

Community feedback

• 

  Mukwende•1,370

  @mukwende2000Posted over 1 year ago

  First of all the label attribute you gave the input is not valid html. so it has no effect, the label is actually an html element that you can use to give a description to your input so it is supposed to be used like so

  <label for="username">Username</label>
  <input id="username">
  

  This will connect the input to the label, the 'for' attribute provided will look for any element that has an id matching the value of its for attribute. CSS resets vary depending on your preference, the most common one i have seen is just

  *, 
  *:before,
  *:after {
  margin: 0;
  padding: 0;
  box-sizing: border-box;
  }
  

  This tells css to match every element in the dom and give it those styles, but you can customize your reset the way you want as you grow as a developer.

  Comments are used to explain code that might not be clear at a glance, so make sure to add comments only you need to; if your code is self explanatory, you don't need to comment it, again if you find yourself writting too many comments, its a sign you need to refactor your code. The time it takes differs from dev to dev depending on your level, a pro developer, and i wouldn't encourage asking how long a project should take lest you get discouraged.

  This is my personal opinion, i believe the best way to not only learn but grow is to do challenging staff, things that scare you, if you run away from those, then how are you goin to become better, it is by getting stuck, frustrated, and banging your head against the keyboard that you get to learn and grow, hope that was helpful. Have a great day.

  Marked as helpful

  0

  ---

  

  Cornflakes•290

  @CornflakesPlusPosted over 1 year ago

  Hey, Mukwende! Thank you for the feedback.

  I used the <label> attribute for styling purposes. I inserted it using a pseudo-class for the Radio style.

  Also, I had a question in mind, are these projects similar to real-world projects? Do you use any other place where you grow more as a developer? Just curious.

  0
• 

  Mukwende•1,370

  @mukwende2000Posted over 1 year ago

  Not sure what your reason was but it is recommended to use classes for styling. I will say yes and no, the projects are not real world in the sense that you will not be hired just to build a simple card component. On the other hand they are indeed real world because the things you will be building might be big projects but are a combination of small little things like the card you built and other projects on frontend mentor. By building these little projects, you won't get stuck when you find that a little part of the big app you are building comperises one of these little thing, so i would yes and no at the same time. As of other places, there is frontend masters which has much big projects. I have not done any there though.

  1
• 

  Cornflakes•290

  @CornflakesPlusPosted over 1 year ago

  I'm having issues with the label tag here, can anyone suggest a fix to this?

  0