Design comparison
Solution retrospective
Really proud of this project! Check out the console(:
Always accepting constructive criticism!
Cheers! Julia
Community feedback
- @danielmrz-devPosted 11 months ago
Hello @ShalomiAhavah!
Your solution looks great!
I have just a couple of suggestions:
-
Add
cursor: pointer;
to the numbers and the button to give the user a visual indication that those elements are clickable. -
Also, replace your
div.card
withmain.card
.
These changes may have little or no visual impact but they make your HTML code more semantic and improve SEO optimization as well as the accessibility of your project.
Other than those details, you did a really good job! 😊
0@ShalomiAhavahPosted 11 months ago@danielmrz-dev Heyy! Thank you so much for your feedback! That just boosted my JS confidence by a bit. I really appreciate the review and will implement your advice immediately!
Thanks again! J
1@danielmrz-devPosted 11 months ago@ShalomiAhavah
I'm glad I could help!
And if my first comment really was useful, please mark it as helpful! 😊
It helps me with the points on the platform 🦾
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord