Design comparison
Solution retrospective
I made this challenge frankly badly, at least there were problems with the background of the card. What can be tweaked to make it better?
Community feedback
- @JanselLopezPosted almost 2 years ago
Hi 😃, for the background of the card you can set the width of you container and manage it with media queries, something like:
.container { width: 500px; } @media (max-width: 510px) { .container { width: 90%; } }
for read about media queries: w3schools/mediaqueries
Marked as helpful1 - @VCaramesPosted almost 2 years ago
Hey there! 👋 Here are some suggestions to help improve your code:
- The “icons/illustrations” in this component are purely decorative. ⚠️ Their
alt tag
should be left blank and have anaria-hidden=“true”
to hide them from assistive technology.
More Info: 📚
[MDN Aria-Hidden] (https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes/aria-hidden#description)
- Your ratings should be wrapped inside a
form
⚠️ and have a visually hiddenlegend
for accessibility and afieldset
to improve semantics.
More Info: 📚
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding! 🎆🎊🪅
Marked as helpful1 - The “icons/illustrations” in this component are purely decorative. ⚠️ Their
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord