Interactive rating component

Community feedback

• 

  Jakub Jirous•270

  @jakubjirousPosted almost 2 years ago

  Hi Jackson,

  Overall, the solution in style.css looks well-written and adheres to some best practices, such as the use of CSS variables and the box-sizing property.

  Here are a few specific comments that could improve the code:

  1) Consider consolidating your font weights: The Overpass font family includes 20 different weights, but you may only need a few of them. Depending on your use case, you might be able to simplify the @import statement and reduce the size of your CSS file.

  2) Use more descriptive class names: The current class names, such as card-one and card-two, are not very informative. Consider using more specific names, such as quiz-card and result-card, to make it clear what each section of the page represents. Consider reordering your properties for better readability. For example, you might group all of the font-related properties together and all of the background-related properties together to make it easier to scan the code.

  3) Use more semantic HTML: The current HTML code doesn't use many semantic elements. Consider restructuring the code to use these elements and make it easier to understand the structure of the page.

  However, other than that, you did an excellent job!

  Cheers, Jakub

  0

  ---

  

  Jackson Silva•30

  @jacks0nsilvaPosted almost 2 years ago

  @jakubjirous

  Hello! Thank you very much for your feedback, without a doubt they were of great help to build good practices! I will make some changes to my code as soon as possible.

  0