Design comparison
Solution retrospective
What you think about it?
Community feedback
- @NJVSPosted about 2 years ago
Great work completing this challenge. I have a little suggestion, you can use
<input type="radio">
instead of<button>
on your ratings. By doing this, you will only need one click event, just for the<button class="btn__submit" id="submit">
. ^_^Marked as helpful1 - @DavidMorgadePosted about 2 years ago
Hey Goorezy, great job completing the solution for this challenge!
I just have a little advice to change in your app, the submit button is submitting even when no rating was selected, and it displays 5 by default, you could add an if check to check if no rating was selected, return an alert that tells the user to select a rating before submitting!
Apart from that I think your application is great, maybe some
hover
effects on your submitbutton
would also fit perfect.Hope my feedback helps you in future challenges, great job!
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord