Design comparison
Community feedback
- @VCaramesPosted almost 2 years ago
Hey there! 👋 Here are some suggestions to help improve your code:
- Do not forget ⚠️ to check your FEM report (It provides value information), to see what is incorrect and update your code with it. This should be done immediately after submitting your challenge.
- Every site should ALWAYS have ✅ a
main
element not only for semantic purposes but also to help assistive technology find the main content of your content. For this challenge, it will serves as the component’s container ⚠️.
More Info: 📚
- Unfortunately, the HTML for the ratings needs to be rewritten as it was done incorrect ❌:
To ensure that the "rating buttons" are fully accessible 💯, they need to be built using a
form
⚠️.- Everything will be wrapped inside a
fieldset
which will have alegend
that is visually hidden using CSS. - Inside, there should be five
input radios
and eachinput
should have alabel
attached to it to make the “ratings” accessible. - The last thing you will want to include will be a
button
so users can submit their choice.
Here is how it looks like fully implemented: EXAMPLE
More Info: 📚
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding! 🎆🎊🪅
Marked as helpful1@KhumboMunsakaPosted almost 2 years ago@vcarames Thanks. I think you are right in what you said. I myself was having trouble deciding what the reviews should be. I didn't even think of using radio buttons
0@VCaramesPosted almost 2 years ago@KhumboMunsaka
Glad I could! 😁
Whenever you want a user to submit any type of info, a
form
is always used.0@VCaramesPosted almost 2 years ago@KhumboMunsaka
If you go your project and scroll past the "design comparison" you will see the report, which will show everything that it found to be incorrect or needs improvement.
0@KhumboMunsakaPosted almost 2 years ago@vcarames What tips do you have so I can get as good as you?
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord