@VCarames
Posted
Hey there! 👋 Here are some suggestions to help improve your code:
- Do not forget ⚠️ to check your FEM report (It provides value information), to see what is incorrect and update your code with it. This should be done immediately after submitting your challenge.
- Every site should ALWAYS have ✅ a
mainelement not only for semantic purposes but also to help assistive technology find the main content of your content. For this challenge, it will serves as the component’s container ⚠️.
More Info: 📚
- Unfortunately, the HTML for the ratings needs to be rewritten as it was done incorrect ❌:
To ensure that the "rating buttons" are fully accessible 💯, they need to be built using a form ⚠️.
- Everything will be wrapped inside a
fieldsetwhich will have alegendthat is visually hidden using CSS. - Inside, there should be five
input radiosand eachinputshould have alabelattached to it to make the “ratings” accessible. - The last thing you will want to include will be a
buttonso users can submit their choice.
Here is how it looks like fully implemented: EXAMPLE
More Info: 📚
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding! 🎆🎊🪅
Marked as helpful
@KhumboMunsaka
Posted
@vcarames Thanks. I think you are right in what you said. I myself was having trouble deciding what the reviews should be. I didn't even think of using radio buttons
@KhumboMunsaka
Posted
@vcarames What is a FEM report?
@VCarames
Posted
@KhumboMunsaka
Glad I could! 😁
Whenever you want a user to submit any type of info, a form is always used.
@VCarames
Posted
@KhumboMunsaka
If you go your project and scroll past the "design comparison" you will see the report, which will show everything that it found to be incorrect or needs improvement.
@KhumboMunsaka
Posted
@vcarames I need to work even harder!
@KhumboMunsaka
Posted
@vcarames What tips do you have so I can get as good as you?
