Design comparison
Solution retrospective
Hey everyone! ๐ Any feedback is much appreciated!
Community feedback
- @VCaramesPosted almost 2 years ago
Hey there! ๐ Here are some suggestions to help improve your code:
- The
form
should only be wrapping the rating buttons.
- There needs to be a
legend
inside theform
but before the first rating.
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding!๐๐
Marked as helpful0@hesam-fattahiPosted almost 2 years ago@vcarames Hey!๐ I hope you're doing well.
I had never heard of the
legend
tag before. ๐ฎBased on what I've read it's the title of the form, but in the design, it's the
h1
tag which is outside the form on top of the section. So what should I write in thelegend
?Thank you for your help.๐
0@VCaramesPosted almost 2 years ago@hesamf01
Remember when creating a site/component you are creating it for users that can see and those that do no have perfect vision.
So users that use screen readers, when they reach the rating section, are greeted with a voice telling them something "Please chose a ratingโฆ". For this challenge it will be visually hidden so only screen readers have access to it.
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/legend
I forgot to mention it in the first comment but you also need a
fieldset
to prevent users from selecting multiple options.https://developer.mozilla.org/en-US/docs/Web/HTML/Element/fieldset
Marked as helpful0 - The
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord