Design comparison
Solution retrospective
Hello there)
That's my first solution on this platform so i have some questions and i will be really grateful for feedback :
- I think my solution isn't that similar to the images in the challenge. I don't have pro subscription(i wasn't using figma/sketch version) so it was hard to set all sizes and colors by eye. What do u think about it?
- Also, I used color picker to find the right colors(from the challenge images) instead of using colors in "style guide.md" file, cause it was one color missing in that file and I was confused by that. The missing color is the color for background of the buttons in untouched state. Is that good approach to use color pickers ?
- I was practicing my vue.js skills. Could you tell something about my approach to this challenge. I think the way i programmed rating buttons isn't the best way. I have separate events and variables for each of them. Any advice ?
- I used
<div>
tags to make boxes to use them as buttons in the rating component, but maybe i should have used styled<input type="checkbox">
in the<form>
instead ?
Community feedback
- @NicolasPirezGitPosted almost 2 years ago
Congrats on your first project!🎉
-
At first glance I can tell it quite matches the original design. I would improve the main box's size though, specially its height. The submit button would look more similar if you changed its
font-weight
to 900 and gave it someletter-spacing
since the characters seem a little bit cramped up. Other than that great work. I ran into the same problem you mentioned about the colors but I had the Figma file so it was easier. Props to you for coming up with the color picker solution to apply them. -
Regarding your last question, I've been told the best way to approach this project is with the use of
<input type="radio">
. It lets you work with the data more efficiently. Perhaps someone more knowledgeable can shed some light as to why but I've seen that reply often in other solutions.
Marked as helpful1 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord