Design comparison
Solution retrospective
the challange is great. give me feedback please.
- how did I get data-* (data-number) in Dom
- is creating the small project like that on single html file is good or bad for site
- color issues like img bg color or botton bg color else I think everything is fine
Community feedback
- @KrishangSharmaPosted over 2 years ago
Colors look fine, but the size are not the same as the design preview.. Also, when I selected a number to rate, it selected all of the previous elements, so you might wanna change that along with the final rating component(The 'You selected _ out of 5' element), it's a bit misaligned, rest looks good! Great job!!
0@Ganesh-RathorPosted over 2 years ago@KrishangSharma Thanks for review . I think i wanna make feedback box like google play,amazon and soon In there feedback when you select 4 star remaining star will automaticaly setected else if you say I Fix my code How is my js dom technique
0@KrishangSharmaPosted over 2 years ago@Ganesh-Rathor Okay!! But since it's based on numbers.. It would be better if the selected number is highlighted only. If it were a star based rating, your's would've been a better approach! As far as the DOM is concerned, it looks a bit complex to me.. There are easy ways to achieve the required result, but hey, everyone has their ways and it's okay. If I can ask you for a favor, I'd ask you to review mine, if possible.. I started today, and it's my first challenge. I'd be happy if you would do it!!
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord