Submitted over 1 year ago
Interactive rating component built with tailwind for first time
@202745EsquedaDaniel
Design comparison
SolutionDesign
Solution retrospective
Feed back Plis
Community feedback
- @0xabdulkhaliqPosted over 1 year ago
Hello there 👋. Congratulations on successfully completing the challenge! 🎉
- I have other recommendations regarding your code that I believe will be of great interest to you.
HTML 🏷️:
- This solution generates accessibility error reports due to
non-semantic
markup, which lack landmark for a webpage
- So fix it by replacing the element
<div class="attribution">
the with semantic element<footer>
in yourindex.html
file to improve accessibility and organization of your page.
- What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like
- They convey the structure of your page. For example, The
<footer>
typically contains information about the author of the section, copyright data or links to related documents.
I hope you find this helpful 😄 Above all, the solution you submitted is great !
Happy coding!
1 - @mdsohailaliPosted over 1 year ago
Hey Bro congratulations on completing the challenge. You've done great job, but i would like to share a little feedback for you, add transition of 0.3s on buttons it'll look good and smooth, and in your solution after submitting the rating you've missed the thank you button. and make the background of rating numbers a little bit of round. Keep going you're doing great, All the best.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord