Interactive Rating Component built with html css and javascript
Design comparison
Solution retrospective
pretty easy, your thoughts ?
Community feedback
- @FluffyKasPosted over 1 year ago
Hello,
Looks good! Works as intended and it's great that you prevented users from submitting the form without a rating. The markup could be improved a bit though:
Instead of a simple div, this should really be a form. And instead of buttons, you could use a checkbox input so the the logic is coupled together (it would be easier to understand for people who don't actually see the screen - i.e. users with screen readers). The inputs themselves can be hidden with css and their labels styled to look like the actual buttons. I know it's unlikely that you'll be rewriting your code but I thought it's nice to be aware of these things, for the future ^^
Apart from this though, great job on the challenge!
Marked as helpful2@deathstarsetPosted over 1 year ago@FluffyKas thank you very much for the review and the advice, I'll try to sort things out with the markup
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord