Design comparison
Community feedback
- @nelsonleonePosted almost 2 years ago
HELLO......congrats on completing this challenge well done 🎉 🎉
I noticed some things with your solution here's some tips , hope this comment was helpful and made meaning to you
You can set
max-width:...
to you content, to limit it from growing / scaling more than it's meant toHope this was helpful and you understood, have fun coding
Marked as helpful0@IagoBomfimPosted almost 2 years ago@nelsonleone Thank you very much for your help, I wasn't able to solve this exact problem
0 - @VCaramesPosted almost 2 years ago
Hey there! 👋 Here are some suggestions to help improve your code:
- The “icons/illustrations” in this component are purely decorative. ⚠️ Their
alt tag
should be left blank and have anaria-hidden=“true”
to hide them from assistive technology.
More Info: 📚
[MDN Aria-Hidden] (https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes/aria-hidden#description)
- To ensure that the "rating buttons" are fully accessible 💯, they need to be built using a
form
⚠️.
- Everything will be wrapped inside a
fieldset
which will have alegend
that is visually hidden using CSS. - Inside, there should be five
input radios
and eachinput
should have alabel
attached to it to make the “ratings” accessible. - The last thing you will want to include will be a
button
so users can submit their choice.
More Info: 📚
- Once the top is implemented , for your JS, the
eventListener
should be on theform
⚠️ as asubmit
.
More Info:📚
Click vs. Submit EventListeners
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding! 🎆🎊🪅
0 - The “icons/illustrations” in this component are purely decorative. ⚠️ Their
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord