Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

CSS custom properties; Flexbox;

@wtwilliams310

Desktop design screenshot for the Interactive rating component coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


All feedback is welcome.

Community feedback

@VCarames

Posted

Hey there! 👋 Here are some suggestions to help improve your code:

  • To not only improve your HTML code but to identify the main content of you page, you will want to wrap your entire component inside the main element.

More Info:📚

MDN Main Element

  • Along with the blank alt tag, you also want to include the aria-hidden=“true” to your “ images/illustrations” to fully remove them from assistive technology.

More Info:📚

https://www.w3.org/WAI/tutorials/images/

  • The proper way to build the "rating buttons" in this challenge is to create a form and inside of it, there should be fiveinput radios and each input should have a label attached to it to make the buttons accessible. Finally wrap all the inputs and labels inside a fieldset to prevent users from making more than one selection.

More Info:📚

MDN <input type="radio">

MDN <fieldset>: The Field Set element

If you have any questions or need further clarification, feel free to reach out to me.

Happy Coding!🎄🎁

Marked as helpful

0

@wtwilliams310

Posted

@vcarames Thanks for the for all of the great suggestions! Very helpful.

1

@Rahulbaran

Posted

Hi Williams, I am Rahul.

I went through your code and here is my feedback:-

Your button is not rounded so instead of using border-radius: 50px, use border-radius: 50%

You have mentioned two font-families in body element. since CSS cascades, there will be not effect of first one, so you can remove one of them.

You can use custom properties for other properties like font-size, font-weight, padding, margin etc too.

You should provide a smaller width for mobile devices by using min() CSS function.

0

@wtwilliams310

Posted

@Rahulbaran Hello Rahul. I greatly appreciate you taking time to look at my code and for the feedback provided. I want to take some time to look over your suggestions, but as I am currently in a bootcamp, it will take me a few days. In the meantime, I wanted to send this reply and ask if it would be okay to ask follow-up questions should they arise?

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord