Design comparison
Solution retrospective
How to make the rating number focus always show when click submit button?
Community feedback
- @VCaramesPosted almost 2 years ago
Hey there! 👋 Here are some suggestions to help improve your code:
- It is best practice ✅ to use,
classes
for styling purposes, while usingids
solely for JavaScript.
- Along with the blank
alt tag
, you also want to include thearia-hidden=“true”
⚠️ to your “ images/illustrations” to fully remove them from assistive technology.
More Info: 📚
[MDN Aria-Hidden] (https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes/aria-hidden#description)
- To ensure that the "rating buttons" are fully accessible 💯, they need to be built using a
form
⚠️.
- Everything will be wrapped inside a
fieldset
which will have alegend
that is visually hidden using CSS. - Inside, there should be five
input radios
and eachinput
should have alabel
attached to it to make the “ratings” accessible. - The last thing you will want to include will be a
button
so users can submit their choice.
More Info: 📚
- It is best practice ✅ to have separate files for you coding files (HTML, CSS, JS). It helps keep things organized and make it easier to maintain.
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding! 🎆🎊🪅
Marked as helpful0 - It is best practice ✅ to use,
- @nelsonleonePosted almost 2 years ago
HELLO......congrats on completing this challenge....well done:🎊 🎊
You can remove the border on the buttons when there are clicked by setting
button:focus{ border:none; outline:none; }
Hope this comment was helpful. Have fun coding
0@tnzgxPosted almost 2 years ago@nelsonleone thank you, but it still the same.
0@nelsonleonePosted almost 2 years ago@tnzgx add !important.
button:focus{ border:none !important; }
make sure you push to your repo so it takes effect
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord