Design comparison
SolutionDesign
Solution retrospective
Your opnion on this work
Community feedback
- @visualdennissPosted over 1 year ago
Your solution looks great as well as responsive! And functions well too. So congrats on completing the challenge succesfully.
It looks like clicking on view code leads to a repo related to another challenge: https://github.com/M2AML/product-preview-card-component-main So you might wanna fix the Repository URL for this challenge.
Hope you find this feedback helpful!
Marked as helpful0 - @0xabdulkhaliqPosted over 1 year ago
Hello there π. Congratulations on successfully completing the challenge! π
- I have other recommendations regarding your code that I believe will be of great interest to you.
HEADINGS β οΈ:
- And, This solution generates accessibility error reports due to lack of level-one heading
<h1>
- Every site must want at least one
h1
element identifying and describing the main content of the page.
- An
h1
heading provides an important navigation point for users of assistive technologies, allowing them to easily find the main content of the page.
- So we want to add a level-one heading to improve accessibility by reading aloud the heading by screen readers, you can achieve this by adding a
sr-only
class to hide it from visual users (it will be useful for visually impaired users)
I hope you find this helpful ! π Above all, the solution you submitted is great
Happy coding!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord