Skip to content
Submitted about 2 years ago

INTERACTIVE RATING COMPONENT

Omar Jalal•110
@omar-jalal
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Interactive rating component
  • HTML
  • CSS
  • JS
1newbie

Design comparison

SolutionDesign

Solution retrospective

What did you find difficult while building the project? Which areas of your code are you unsure of? Do you have any questions about best practices?

Community feedback

  • Lucas 👾•104,340
    @correlucasPosted about 2 years ago

    👾Hello @tiger8707, Congratulations on completing this challenge!

    Great code and great solution! I’ve few suggestions for you that you can consider adding to your code:

    1.Add transitions to make the interaction smoother while the element gets hovered, you can use a value like transition: all ease-in 0.5s.

    2.To improve the card overall responsibility, you can start to add flex-wrap inside the class that manages the section for the rating numbers button and makes the adjust to fit in different rows while the container scales down, not that without this property the container doesn't shrink. Here's the code applying these changes:

    .rating-window .rating {
    display: flex;
    justify-content: space-between;
    margin-top: 1.7em;
    width: 100%;
    flex-wrap: wrap;
}

    ✌️ I hope this helps you and happy coding!

    Marked as helpful
    1
    Omar Jalal•110
    @omar-jalalPosted about 2 years ago

    @correlucas Thanks for the tips!

    1
  • Adriano•38,390
    @AdrianoEscarabotePosted about 2 years ago

    Hi Omar Galal, how are you?

    I really liked the result of your project, but I have some tips that I think you will like:

    1- Every page should have one main landmark <main>. So replace the div that wraps the whole content with <main> to improve the accessibility. click here

    2- All page content should be contained by landmarks, you can understand better by clicking here: click here

    We have to make sure that all content is contained in a reference region, designated with HTML5 reference elements or ARIA reference regions.

    Example:

    native HTML5 reference elements:

    <body>
    <header>This is the header</header>
    <nav>This is the nav</nav>
    <main>This is the main</main>
    <footer>This is the footer</footer>
</body>

    ARIA best practices call for using native HTML5 reference elements instead of ARIA functions whenever possible, but the markup in the following example works:

    <body>
     <div role="banner">This is the header</div>
     <div role="navigation">This is the nav</div>
     <div role="main">This is the main</div>
     <div role="contentinfo">This is the footer</div>
</body>

    It is a best practice to contain all content, except skip links, in distinct regions such as header, navigation, main, and footer.

    Link to read more about: click here

    2- Why it Matters

    Navigating the web page is far simpler for screen reader users if all of the content splits between one or more high-level sections. Content outside of these sections is difficult to find, and its purpose may be unclear.

    HTML has historically lacked some key semantic markers, such as the ability to designate sections of the page as the header, navigation, main content, and footer. Using both HTML5 elements and ARIA landmarks in the same element is considered a best practice, but the future will favor HTML regions as browser support increases.

    Rule Description

    It is a best practice to ensure that there is only one main landmark to navigate to the primary content of the page and that if the page contains iframe elements, each should either contain no landmarks, or just a single landmark.

    Link to read more about: click here

    Prefer to use rem over px to have your page working better across browsers and resizing the elements properly

    The rest is great!!

    Hope it helps...👍

    Marked as helpful
    1
    Omar Jalal•110
    @omar-jalalPosted about 2 years ago

    @AdrianoEscarabote Thanks for your feedback!

    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord