Design comparison
SolutionDesign
Solution retrospective
Hi there!
Here's my solution for this challenge. It is my pleasure to hear your feedback. Questions appreciated!
Cheers!
Community feedback
- @catherineisonlinePosted almost 2 years ago
It shows me that I chose options 1 for every other option, might want to fix that π
Marked as helpful0 - @VCaramesPosted almost 2 years ago
Hey there! π Here are some suggestions to help improve your code:
- βicons/illustrationsβ in this component serve no other purpose than to be decorative; They add no value. There
alt tag
should be left blank and have anaria-hidden=βtrueβ
to hide them from assistive technology.
More Info:π
https://www.w3.org/WAI/tutorials/images/
- The proper way to build the "rating buttons" in this challenge is to create a
form
and inside of it, there should be fiveinput radios
and eachinput
should have alabel
attached to it to make the buttons accessible. Finally wrap all theinputs
andlabels
inside afieldset
to prevent users from making more than one selection.
More Info:π
MDN <fieldset>: The Field Set element
- The
attribution
should be wrapped in afooter
element.
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding!ππ
Marked as helpful0 - βicons/illustrationsβ in this component serve no other purpose than to be decorative; They add no value. There
- @wagnerk78Posted almost 2 years ago
- I found a little mistake. When I am selectioning a number different, the page of confirmation doesn't change. For example, if I selection number 3, the text is: You selected 1 out of 5. I think that it should change for: You selected 3 out of 5.
- You built the site correctly and I didn't find any other errors that I could observe.
- Keep going!
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord