Design comparison
Solution retrospective
"Feedback welcome" =D
Community feedback
- @Cristhyam-AugustoPosted almost 2 years ago
Hello @JcCaldas, how are you? Congratulations for the work, it turned out very well. I noticed that you used a javascript function to change the color of items when hovering the mouse (mouseover), however, you can do this with just css
.item:hover { background color: hsl(25, 97%, 53%); color: hsl(0, 0%, 100%); }
The same goes for the submit button. I hope the feedback was helpful, please don't hesitate to MARKED AS HELPFUL, thanks. Happing coding.
Marked as helpful1 - @VCaramesPosted almost 2 years ago
Hey there! 👋 Here are some suggestions to help improve your code:
- To not only improve your HTML code but to identify the main content of you page, you will want to wrap your entire component inside the
main
element.
More Info:📚
- Along with the blank
alt tag
, you also want to include thearia-hidden=“true”
to your “ images/illustrations” to fully remove them from assistive technology.
More Info:📚
https://www.w3.org/WAI/tutorials/images/
- The proper way to build the "rating buttons" in this challenge is to create a
form
and inside of it, there should be fiveinput radios
and eachinput
should have alabel
attached to it to make the buttons accessible. Finally wrap all theinputs
andlabels
inside afieldset
to prevent users from making more than one selection.
More Info:📚
MDN <fieldset>: The Field Set element
- The
attribution
should be wrapped in afooter
element.
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding!🎄🎁
0 - To not only improve your HTML code but to identify the main content of you page, you will want to wrap your entire component inside the
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord