Design comparison
Solution retrospective
I am very proud of this challenge, because I think I did it very well. Since I am a beginner, I thought that javascript would be a big problem for me, but I easily found solutions to my doubts on the Internet.
I got the idea for the rate-again button from a YouTuber I came across while solving the challenge.
If you have any advice or remark, feel free to let me know, and I will do my best to do the next challenge even better.
Community feedback
- @VCaramesPosted almost 2 years ago
Hey there! 👋 Here are some suggestions to help improve your code:
Unfortunately, the HTML needs to be rewritten for the rating buttons as it is incorrect ❌.
- Do not forget ⚠️ to check your FEM report (It provides value information), to see what is incorrect and update your code with it. This should be done immediately after submitting your challenge.
- The
article
element is being used incorrectly ⚠️ and not needed for this challenge .
- Every site should ALWAYS have ✅ a
main
element not only for semantic purposes but also to help assistive technology find the main content of your content. For this challenge, it will serves as the component’s container ⚠️.
More Info: 📚
- The “icons/illustrations” in this component are purely decorative. ⚠️ Their
alt tag
should be left blank to hide them from assistive technology.
More Info:📚
https://www.w3.org/WAI/tutorials/images/
- To ensure that the "rating buttons" are fully accessible 💯, they need to be built using a
form
⚠️.
- Everything will be wrapped inside a
fieldset
which will have alegend
that is visually hidden using CSS. - Inside, there should be five
input radios
and eachinput
should have alabel
attached to it to make the “ratings” accessible. - The last thing you will want to include will be a
button
so users can submit their choice.
More Info: 📚
- Once the top is implemented , for your JS, the
eventListener
should be on theform
⚠️ as asubmit
.
More Info:📚
Click vs. Submit EventListeners
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding! 🎆🎊🪅
Marked as helpful0@4jdinPosted almost 2 years ago@vcarames Thanks for the advice, it means a lot to me when I get criticism or advice from someone so that I can improve my code, and I will try my best to make the code as good as possible.
1 - @4jdinPosted almost 2 years ago
Hello, I just want to inform you that I have fixed all the errors in the code and that you can now use it if you need it.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord