Design comparison
Solution retrospective
I need to figure out how to add to the functionality that the ratings must be selected first before submission. I will need to further investigate.
Community feedback
- @VCaramesPosted almost 2 years ago
Hey there! 👋 Here are some suggestions to help improve your code:
- The
section
element is being used incorrectly ⚠️ and not needed for this challenge .
- To ensure that the "rating buttons" are fully accessible 💯, they need to be built using a
form
⚠️.
- Everything will be wrapped inside a
fieldset
which will have alegend
that is visually hidden using CSS. - Inside, there should be five
input radios
and eachinput
should have alabel
attached to it to make the “ratings” accessible. - The last thing you will want to include will be a
button
so users can submit their choice.
More Info: 📚
- Once the top is implemented , for your JS, the
eventListener
should be on theform
⚠️ as asubmit
.
More Info:📚
Click vs. Submit EventListeners
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding! 🎆🎊🪅
Marked as helpful0@CryptoFallenPosted almost 2 years ago@vcarames Thank you for your feedback as always, I definitely will look into these suggestions and fix these issues, it didn't really occur to me about using the form for this, but makes sense as I can then utilize the required property to ensure a number is chosen.
1@VCaramesPosted almost 2 years ago@CryptoFallen
Glad I could help.
Any time you need users to submit any type of info (reviews, email, etc..) you will always use a
form
.Marked as helpful1 - The
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord