Interactive rating component

Community feedback

• 

  P

  Fluffy Kas•7,715

  @FluffyKasPosted over 2 years ago

  Heyo,

  It looks good! In addition to what @Sdann26 already said, you could look into the following:

  1. Instead of using buttons, radio inputs are a better choice for the ratings.

  2. You shouldn't set a fixed height on your card - or in general on most elements. If you remove it, you'll see little has changed. This is because html elements have their own default height. You can add some padding to this, if it isn't enough.

  3. You could add a rule to prevent empty submits.

  And yes, you should always upload your scss files to Github. If someone tried to look into your code, the scss you worked on is usually easier to follow than the complied css. ^^

  Marked as helpful

  2
• 

  Danilo Blas•6,300

  @Sdann26Posted over 2 years ago

  Hi Jona! Congratulations on finishing your first project!

  You should never delete them, since you program in a development environment so you modify those files in development. The files that are generated are passed to a production environment that has better performance for your page, more or less this is how it is handled. You will see that later on when you get more experience.

  Leaving aside the question, in your design the star does not appear and it is because you have not used relative paths. So modify <img alt="" src="/images/icon-star.svg"> to <img alt="" src="./images/icon-star.svg">, you will notice that it has a dot before the slash as that is a relative path because it starts from where the file that calls the path is located.

  If you want to make the spacing in the SUBMIT button you can add the attribute letter-spacing: 0.25em, also you can add to this button and to the score buttons the attribute to give a transition to the change of state and that the effects are given more smoothly transition: all 200ms.

  I hope my comments are helpful.

  Marked as helpful

  2