Design comparison
SolutionDesign
Solution retrospective
Feedback is appreciated!
Community feedback
- @mseidel819Posted over 2 years ago
I like the creativity on the button colors!
a couple accessibility fixes:
- Change
<div class="continer">
to<main class="continer">
- Change
<div class="attribution" role="footnote">
to <footer class="attribution"> - I think you can also get away with changing
<h2 class="heading">How did we do?</h2>
to an<h1>
element. - on line 12 of your index.html, in
type="text/javascript"
.
Other things you can look into:
- when you hover over the number buttons and the submit, cursor should be a pointer.
cursor:pointer
. - when you hover over submit, the background should change to white, and the text should change to orange.
Marked as helpful1@BiscuitCandyPosted over 2 years ago@mseidel819 Thank you for the feedback! I always want to try making my html a bit professional but not know when to use those tags. Your fixes gave me the insight I needed.
0 - Change
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord