Design comparison
Solution retrospective
A few challenges for the javascript but got it eventually. Welcome any tips for javascript.
Community feedback
- @AdrianoEscarabotePosted almost 2 years ago
Hi naomichoe, how are you? I really liked the result of your project, but I have some tips that I think you will enjoy:
To make the submit button work only when the user selects a number, we can do this:
ratings.forEach((rate) => { rate.addEventListener("click", () => { submittedRating.innerHTML = rate.innerHTML; submitButton.addEventListener("click", () => { ratingContainer.style.display = "none"; thankYouContainer.classList.remove("hidden"); }) }) })
The rest is great!
I hope it helps... π
Marked as helpful0 - @VCaramesPosted almost 2 years ago
Hey there! π Here are some suggestions to help improve your code:
- To not only improve your HTML code but to identify the main content of you page, you will want to wrap your entire component inside the
main
element.
More Info:π
- The βicons/illustrationsβ in this component serve no other purpose than to be decorative; They add no value. There
alt tag
should be left blank and have anaria-hidden=βtrueβ
to hide them from assistive technology.
More Info:π
https://www.w3.org/WAI/tutorials/images/
- The proper way to build the "rating buttons" in this challenge is to create a
form
and inside of it, there should be fiveinput radios
and eachinput
should have alabel
attached to it to make the buttons accessible. Finally wrap all theinputs
andlabels
inside afieldset
to prevent users from making more than one selection.
More Info:π
MDN <fieldset>: The Field Set element
- The
attribution
should be wrapped inside afooter
element.
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding!ππ
0 - To not only improve your HTML code but to identify the main content of you page, you will want to wrap your entire component inside the
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord