Design comparison
Solution retrospective
Any feedback is appreciated
Community feedback
- @VCaramesPosted almost 2 years ago
Hey there! 👋 Here are some suggestions to help improve your code:
- To not only improve your HTML code but to identify the main content of you page, you will want to wrap your entire component inside the
main
element.
More Info:📚
- Along with the blank
alt tag
, you also want to include thearia-hidden=“true”
to your “ images/illustrations” to fully remove them from assistive technology.
More Info:📚
https://www.w3.org/WAI/tutorials/images/
- The proper way to build this challenge is to create a
form
and inside of it, the “rating buttons” should be built using aninput radio
(wrap all of them inside afieldset
), since this will prevent additional buttons from being active at the same time, and it should have alabel
element attached to it for accessibility.
More Info:📚
MDN <fieldset>: The Field Set element
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding!🎄🎁
Marked as helpful1 - To not only improve your HTML code but to identify the main content of you page, you will want to wrap your entire component inside the
- @Deevyn9Posted almost 2 years ago
Hi John, congrats on completing this project, it looks really good. However, the container isn't responsive for screens below 340px, try changing the
width
tomax-width
and adding left and right padding to the body so it can look great on smaller screens> Also, you'll need to swap the hover and active colors on the radio buttons.I hope you find this helpful.
Happy Coding! 🎉
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord