Design comparison
SolutionDesign
Community feedback
- @romila2003Posted about 2 years ago
Hi Ben,
Congratulations 🎉 for completing this challenge, the card looks great and is functional. However, there is an accessibility issue regarding your HTML and CSS.
- It is best practice to wrap your code within the
main
tag which would ensure that your content is wrapped within the correct landmarks e.g.<main class="container"></main>
- It is good that you used the flexbox property to center and align your card however you can remove the
flex-direction
ofcolumn
property. Also, you can change themargin
property tomargin: 0 20px;
instead, to prevent the card from touching the side of the screen.
Overall, great attempt and wish you the best for your future projects.
Marked as helpful1 - It is best practice to wrap your code within the
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord