Design comparison
Solution retrospective
Why is this challenge marked as easy / newbie?! It requires a some JavaScript knowledge and in advance thinking!
Community feedback
- @catherineisonlinePosted almost 2 years ago
Because higher level projects are even harder :))
1 - @Nadine-GreenPosted almost 2 years ago
HEY THERE!
Your solution is very nice however I would like to draw your eye to some of the accessibility errors you have, a quick fix to one of them would be to replace the
div
element assigned to the.attribution
with a semantic one likefooter
, this should solve it, not only will your page be more accessible but you will have one less error.IF THIS WAS HELPFUL IN ANY WAY, DON'T HESITATE TO MARK IT AS HELPFUL :)
HAPPY CODING!
0 - @VCaramesPosted almost 2 years ago
Hey there! 👋 Here are some suggestions to help improve your code:
- There needs to be a visually hidden
legend
to improve accessibility and afieldset
to prevent users from making more than one selection inside yourform
.
- The
attribution
should be wrapped in afooter
element.
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding!🎄🎁
0 - There needs to be a visually hidden
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord