Design comparison
SolutionDesign
Solution retrospective
My first JS challenge, it was fun doing it. I did my best. Learn so many new things, still if have any feedback is most welcome.
keep learning... keep coding.... keep growing...
Community feedback
- @fatlindshehuPosted over 2 years ago
Hello Rajesh, Great job with the task, I would recommend you some changes:
- Don't set the width of the body to a specific px
- When using flex to center an element you need the height to be defined (usually 100vh to the parent element of the card)
- Don't use px units instead convert them to rem units.
- The background of the card is a gradient so use this link to know how to make a gradient
- Check the colors in the style guide to set them 100% as in the design.
Marked as helpful2@Rajesh7rjPosted over 2 years ago@fatlindshehu Thanks mate, for your valuable feedback.
I definitely work on that. you are right i'will use "rem" instead of "px". also about other things you mention.
I just started learning of front end, so your feedback is add value to my learning.
best wishes to you ....
0@fatlindshehuPosted over 2 years ago@Rajesh7rj No problem, we improve by helping each other!
All the best!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord