Design comparison
Solution retrospective
When I have two different html pages how do I handle JavaScript files? I use main.js for index.html and using html script elements for the other html pages.
Community feedback
- @Orekihotarou-kPosted 3 months ago
Hey @matt2282, great job on completing the challenge! 🎉 There are a couple of things that could make your solution even better:
-
HTML Structure: It might be simpler to have all the HTML in one file. This way, everything is in one place, making it easier to manage and update.
-
Modal Display: For the thank you modal, you can set its styles to
display: none
by default, and then use JavaScript to change it todisplay: block
when it's time to show it. At the same time, you could hide the rating container withdisplay: none
when the thank you modal is displayed. This would make the transition smoother and more intuitive. -
Deployment: I recommend deploying your project using Vercel or Netlify. GitHub Pages can sometimes be unstable, and right now, I'm unable to view your solution because of it.
What do you think? 😊
0 -
- @Orekihotarou-kPosted 3 months ago
Hey @matt2282, great job on completing the challenge! 🎉 There are a couple of things that could make your solution even better:
-
HTML Structure: It might be simpler to have all the HTML in one file. This way, everything is in one place, making it easier to manage and update.
-
Modal Display: For the thank you modal, you can set its styles to
display: none
by default, and then use JavaScript to change it todisplay: block
when it's time to show it. At the same time, you could hide the rating container withdisplay: none
when the thank you modal is displayed. This would make the transition smoother and more intuitive. -
Deployment: I recommend deploying your project using Vercel or Netlify. GitHub Pages can sometimes be unstable, and right now, I'm unable to view your solution because of it.
What do you think? 😊
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord