Design comparison
Solution retrospective
Hi fellow coder's π I have on question for you brother's
- If there is any way to make the thanks card in a separate html and get the rating from the rating html page when the user click the submit
Community feedback
- @VCaramesPosted almost 2 years ago
Hey there! π Here are some suggestions to help improve your code:
- The βicons/illustrationsβ in this component serve no other purpose than to be decorative; They add no value. There
alt tag
should be left blank and have anaria-hidden=βtrueβ
to hide them from assistive technology.
More Info:π
https://www.w3.org/WAI/tutorials/images/
- The proper way to build the "rating buttons" in this challenge is to create a
form
and inside of it, there should be fiveinput radios
and eachinput
should have alabel
attached to it to make the buttons accessible. Finally wrap all theinputs
andlabels
inside afieldset
to prevent users from making more than one selection.
More Info:π
MDN <fieldset>: The Field Set element
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding!ππ
Marked as helpful0@vigneshajithPosted almost 2 years ago@vcarames Hi fellow coder your post was really helpful to me. I have no idea about assistive. From now on am go to learn this is things. thank you very much for let me know. **Happy Coding! ** ππ
1 - The βicons/illustrationsβ in this component serve no other purpose than to be decorative; They add no value. There
- @AdrianoEscarabotePosted almost 2 years ago
Hi vigneshajith, how are you? I really liked the result of your project, but I have some tips that I think you will enjoy:
To make the
submit
button work only when the user selects a number we can do this:ratebtn.forEach((ratebtn) => { ratebtn.addEventListener("click", () => { rating.innerHTML = ratebtn.innerHTML; submit.addEventListener("click", () => { thanks.classList.remove("hidden"); container.style.cssText = "display:none"; }) }); });
The rest is great!
I hope it helps... π
Marked as helpful0@vigneshajithPosted almost 2 years ago@AdrianoEscarabote Thank you for sharing your knowledge. It was really helpful ππ
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord