Interactive rating component

Community feedback

• 

  バレンタイン 😈•64,170

  @VCaramesPosted almost 2 years ago

  Hey there! 👋 Here are some suggestions to help improve your code:

  • The “icons/illustrations” in this component serve no other purpose than to be decorative; They add no value. There alt tag should be left blank and have an aria-hidden=“true” to hide them from assistive technology.

  More Info:📚

  https://www.w3.org/WAI/tutorials/images/

  • The proper way to build the "rating buttons" in this challenge is to create a form and inside of it, there should be fiveinput radios and each input should have a label attached to it to make the buttons accessible. Finally wrap all the inputs and labels inside a fieldset to prevent users from making more than one selection.

  More Info:📚

  MDN <input type="radio">

  MDN <fieldset>: The Field Set element

  If you have any questions or need further clarification, feel free to reach out to me.

  Happy Coding!🎄🎁

  Marked as helpful

  1

  ---

  

  Nicolás F•180

  @nicolasfigPosted almost 2 years ago

  @vcarames Thank you I'll keep that in mind and will update the project when I have some free time

  1
• 

  Adriano•38,390

  @AdrianoEscarabotePosted almost 2 years ago

  Hello Nicolas F, how are you? I truly loved your project's outcome, however I have some advice that I hope you'll find useful:

  To make the submit button work only when the user selects a number we can do this:

  scores.forEach((score) => {
    score.addEventListener("click", () => {
      final_score.innerHTML = score.innerHTML;
      submit_btn.addEventListener("click", () => {
        pre_submitted.style.display = "none";
        submitted.style.display = "flex";
      });
    });
  });
  

  The remainder is excellent.

  I hope it's useful. 👍

  Marked as helpful

  1

  ---

  

  Nicolás F•180

  @nicolasfigPosted almost 2 years ago

  @AdrianoEscarabote Thank you so much! Totally forgot about that

  1