Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Interactive rating component

@JasonSolarz

Desktop design screenshot for the Interactive rating component coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

@volkanguneri

Posted

Awesome!

I can suggest you in CSS

1-

background-image: url('images/icon-star.svg') center center / cover no repeat;

instead of

background-image: url(images/icon-star.svg); background-repeat: no-repeat; background-position: center;

2-

use of rem and em instead of pixels

3-

u can also use css :active proporty instead of javascript here by adding tabindex="1" to your "li" in HTML.

li:active { color: hsl(0, 0%, 100%); background-color: hsl(217, 12%, 63%); }

instead of creating a new css class

.selected { color: hsl(0, 0%, 100%); background-color: hsl(217, 12%, 63%); }

4- you can also manipulate css directly by javascript DOM instead of creating a new css class like

.display-not { display: none; }

main.style.display = 'none'; section.style.display = 'block';

I hope that it can make more economy.

I also learned from your javascript code.

Thanks

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord