Design comparison
Solution retrospective
I still difficult to make rating number. For now, I using input radio. Maybe anyone know another solution to make rating number more easy and simple? Thanks.
Community feedback
- @denieldenPosted over 2 years ago
Hi Muhammad, great work on this challenge! 😉
Here are a few tips for improve your code:
- add
main
tag and wrap the card for improve the Accessibility - use
min-height: 100vh
insteadheight
to.container
class - add
transition
on the element with hover effect - instead of using
px
use relative units of measurement likerem
-> read here - instead of using an
input
you can use abutton
or a simplediv
to which you associate anid
and the click retrieves the id so that you know how many stars have been chosen
Overall you did well 😁 Hope this help!
Marked as helpful1@naufalf25Posted over 2 years ago@denielden Thanks for your feedback. I will try to improve my code follow your suggestion 😄
1 - add
- @boedegoatPosted over 2 years ago
Great work @naufalf25
You did the project pretty good. The rating system works well. But, it seems like you forgot to handle a case where user is immediately click on submit button without selecting any rating. As a result it will display 'You selected undefined out of 5'.
Other than that, keep learning and enjoy coding ☕
1@naufalf25Posted over 2 years ago@boedegoat Are you sure? Though I've tested it and it's normal. Okay, I will evaluated it again. Thanks for your feedback :D
0@naufalf25Posted over 2 years ago@boedegoat And can you share the console in your browser when opening my solution? Because, my friend just open it too but it's normal nothing error
0@boedegoatPosted over 2 years ago@naufalf25 Coba langsung klik tombol submit nya bang tanpa milih rating.
0@naufalf25Posted over 2 years ago@boedegoat Oh iya itu masih kekurangan. Nanti coba tak perbaiki lagi ehehe. Makasih masukannya 🙏🏻
0@naufalf25Posted over 2 years ago@boedegoat Monggo bisa dicek lagi, sudah saya perbaiki scriptnya hehe
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord