Design comparison
Solution retrospective
Proud of making this project in my given period of time. Next time I want to reduce more time in making this.
What challenges did you encounter, and how did you overcome them?It was not so challenging but I forgot about the focus state of the button which consumed my time 😅
What specific areas of your project would you like help with?Open for your suggestions 😃
Community feedback
- @ilyesabPosted 8 months ago
Hi @DivasJaglan, Your solution looks great!
I like how you included your personal touch using linear gradients and so on to customise the design.
A few notes from my side:
-
I believe you should have use h1 vs h2 in the html. since you already set the font-size using CSS I believe using an h1 is semantically better.
-
You create spacing mainly using flexbox and the gap property. I would advise you to look at grid as it allow you do the same but saving few CSS Lines.
-
The content looks a little bit squished on mobile and the paragraph looks vertically squished so maybe decrease the padding of the main container and give the paragraph a line-height and maybe a bigger font. though it still looks nice without all of that.
Over all I think you did a great job!
Marked as helpful0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord