Design comparison
SolutionDesign
Community feedback
- @kaamiikPosted 1 day ago
- You need to re structure your html. You have a form with submit button. Inside your form you have a group of radio buttons. each radio button needs a label too. For group of radio buttons You need to wrap them in a
fieldset
and the question needs to wrap inside alegend
.
- Try to use a proper CSS reset at the start of your CSS style. Andy Bell and Josh Comeau both have a good one. You can simply search on the internet to find them.
- Your
max-width: 374px;
should be in rem unit.
- Your
font-size
andmax-width
should be inrem
unit notpx
. You can read this article about it and why you should not usepx
as a font-size.
- Instead of width and height add a padding to your button.
0 - You need to re structure your html. You have a form with submit button. Inside your form you have a group of radio buttons. each radio button needs a label too. For group of radio buttons You need to wrap them in a
- @Mahmoud-Abdelkarim777Posted 2 days ago
- i loved your coding ,it is awesome
- wishing the best for you
0@bcmdev20Posted 2 days ago@Mahmoud-Abdelkarim777 Thank you, it's nice to have good feedback, given that I'm learning coding on my own.
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord