Interactive Rating Component

Community feedback

• 

  Adriano•38,060

  @AdrianoEscarabotePosted almost 2 years ago

  Hello Anubhav Ray, how are you? I truly loved your project's outcome, however I have some advice that I hope you'll find useful:

  To make the submit button work only when the user selects a number, we can make some changes:

  for (let i = 0; i < list.length; i++) {
    list[i].addEventListener("click", function (event) {
      list[i].classList.toggle("clicked");
      selectEl = event.target;
      submit.addEventListener("click", function () {
        document.querySelector(".Rate-Container").classList.add("hidden");
        document.querySelector(".ThankYou-Container").classList.remove("hidden");
        document.querySelector(".container").classList.add("width");
        document.querySelector(".select").textContent = `${selectEl.textContent}`;
      });
    });
  }
  

  The remainder is excellent.

  I hope it's useful. 👍

  Marked as helpful

  1
• 

  👾 Ekaterine Mitagvaria 👾•7,600

  @catherineisonlinePosted almost 2 years ago

  Nice! 🙌🏻

  I would also add some transitions for active states (when colors change on hover). It creates more interactivity and makes the project looks cooler. Active states can be done on buttons, links, titles which act like links or anything else, you choose.

  You can read more about it here, in case you haven’t done much of it:
https://www.w3schools.com/css/css3_transitions.asp

  IF THIS WAS HELPFUL PLEASE MARK IT AS HELPFUL 🤩

  Marked as helpful

  0
• 

  バレンタイン 😈•64,190

  @VCaramesPosted almost 2 years ago

  Hey there! 👋 Here are some suggestions to help improve your code:

  • The “icons/illustrations” in this component serve no other purpose than to be decorative; They add no value. There alt tag should be left blank and have an aria-hidden=“true” to hide them from assistive technology.

  More Info:📚

  https://www.w3.org/WAI/tutorials/images/

  • The proper way to build the "rating buttons" in this challenge is to create a form and inside of it, there should be fiveinput radios and each input should have a label attached to it to make the buttons accessible. Finally wrap all the inputs and labels inside a fieldset to prevent users from making more than one selection.

  More Info:📚

  MDN <input type="radio">

  MDN <fieldset>: The Field Set element

  • Currently, users can submit without selecting a rating. To fix this, you can do one of the following:

  1. Make the “5” rating the default rating.
  2. Create an error message, telling users they need make a section.
  3. Disable the button until a selection is made.

  If you have any questions or need further clarification, feel free to reach out to me.

  Happy Coding!🎄🎁

  Marked as helpful

  0