Design comparison
SolutionDesign
Solution retrospective
All Feedbacks are welcome );
Community feedback
- @VCaramesPosted almost 2 years ago
Hey there! 👋 Here are some suggestions to help improve your code:
- The “icons/illustrations” in this component serve no other purpose than to be decorative; They add no value. There
alt tag
should be left blank and have anaria-hidden=“true”
to hide them from assistive technology.
More Info:📚
https://www.w3.org/WAI/tutorials/images/
- The proper way to build the "rating buttons" in this challenge is to create a
form
and inside of it, there should be fiveinput radios
and eachinput
should have alabel
attached to it to make the buttons accessible. Finally wrap all theinputs
andlabels
inside afieldset
to prevent users from making more than one selection.
More Info:📚
MDN <fieldset>: The Field Set element
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding!🎄🎁
1 - The “icons/illustrations” in this component serve no other purpose than to be decorative; They add no value. There
- @AdrianoEscarabotePosted almost 2 years ago
Hello John Selastin, how are you? I truly loved your project's outcome, however I have some advice that I hope you'll find useful:
To make the submit button work only when the user selects a number, we can do this:
ratingBtn.forEach(btn=>{ btn.addEventListener('click',()=>{ rating.innerHTML=btn.innerHTML console.log(btn.innerHTML) submitBtn.addEventListener("click",()=>{ thankyouConatiner.classList.remove("hidden"); ratingsContainer.classList.add('hidden'); }) }) })
The remainder is excellent.
I hope it's useful. 👍
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord