Interactive Rating Component

Community feedback

• 

  Thomas Hertog•825

  @thomashertogPosted over 1 year ago

  Solution is looking good (visually). There are some things to improve your code though.

  HTML

  • you have a <button type="submit"> but there is no <form>
  • the star image is decorative (at least in my opinion) so it should have aria-hidden attribute
  • the ratings should be an <input type="radio"> in order for the form to submit meaningful data. you can find more info here
  • you might want to work with a hidden attribute for the thank you container in order to remove it from your accessibility tree as well until the form is submitted

  CSS looks clean, couldn't find improvements there however, you may want to remove those commented lines as they distract you from the code that is needed

  Marked as helpful

  0