Interactive rating component

Community feedback

• 

  Thomas•450

  @TomSifPosted about 1 month ago

  Honestly, I'm not very comfortable commenting your work given my current level and above all I have the impression that your project is much more concise and your code clearer, but I can still try to give you some points of improvements :

  • I don't really understand the use of input for radio buttons, is it for accessibility reasons or just to retrieve their respective values? Because we could access the button value via data-rating = '1' and make the button readable by readers via adding an aria-label.
  • Don't forget to add meta description and meta keywords tags for SEO
  • It is better to use font-face to load and store your fonts, you will find most font-google in woff2 format (lighter) here: https://gwfh.mranftl.com/fonts
  • I invite you to check the modern reset css: https://www.joshwcomeau.com/css/custom-css-reset/
  • Your buttons are not animated, a small button:active with an animation would be nice for the feeling of clicking on something

  So I hope these little tips can help you and congratulations again for the quality of your work, keep coding, good luck :)

  Marked as helpful

  0

  ---

  

  Eugenia Antonova•400

  @EugeniaAntonovaPosted 19 days ago

  @TomSif Thank you very much, Thomas! It is very sweet of you to appreciate my work and to asses it in such detail! I will deffinetely use the tips you gave me in futrther projects. Good luck on your way too ❤, hope to see your comments on my ongoing projects aswell!

  p.s.: with radio-buttons the solution was chosen because I thought that it is semanticly good option and gives the user an opportunity to navigate them with arrows in their kewboard

  1

  

  Thomas•450

  @TomSifPosted 18 days ago

  @EugeniaAntonova

  • you are welcome, thanks for your reply :)
  • yes you are right about radio buttons that make sens , now ! ( I'm a bit slow to catch on ).
  • see you on another project !

  0