@VCarames
Posted
Hey there! 👋 Here are some suggestions to help improve your code:
- Every component/site should always have ✅ the following two, a
main
andh1
element (if this was a larger challenge, it would be a different heading level).
- To ensure that the "rating buttons" are fully accessible 💯, they need to be built using a
form
⚠️.
- Everything will be wrapped inside a
fieldset
which will have alegend
that is visually hidden using CSS. - Inside, there should be five
input radios
and eachinput
should have alabel
attached to it to make the “ratings” accessible. - The last thing you will want to include will be a
button
so users can submit their choice.
More Info: 📚
- Currently ⚠️, users can submit without selecting a rating. To fix this, you can do one of the following:
- Make the “5” rating the default rating.
- Create an error message, telling users they need make a selection.
- Disable the button until a selection is made.
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding! 🎆🎊🪅
Marked as helpful
@mariby21
Posted
@vcarames Thank you
@mariby21
Posted
@vcarames i do some changes how its now :)
@VCarames
Posted
@mariby21
The rating "buttons" are still being built incorrect. The way I mentioned previously, is the only way to complete this challenge correctly.
The section
element that you added, is being used incorrectly ⚠️ and not needed for this challenge .
The form
should be outside the fieldset
.