Design comparison
SolutionDesign
Community feedback
- @VCaramesPosted almost 2 years ago
Hey there! 👋 Here are some suggestions to help improve your code:
- To not only improve your HTML code but to identify the main content of you page, you will want to wrap your entire component inside the
main
element.
More Info:📚
- Along with the blank
alt tag
, you also want to include thearia-hidden=“true”
to your “ images/illustrations” to fully remove them from assistive technology.
More Info:📚
https://www.w3.org/WAI/tutorials/images/
- The proper way to build the "rating buttons" in this challenge is to create a
form
and inside of it, there should be fiveinput radios
and eachinput
should have alabel
attached to it to make the buttons accessible. Finally wrap all theinputs
andlabels
inside afieldset
to prevent users from making more than one selection.
More Info:📚
MDN <fieldset>: The Field Set element
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding!🎄🎁
Marked as helpful0 - To not only improve your HTML code but to identify the main content of you page, you will want to wrap your entire component inside the
- @AdrianoEscarabotePosted almost 2 years ago
Hello Sunil Sharma, how are you? I truly loved your project's outcome, however I have some advice that I hope you'll find useful:
To make the submit button work only when the user selects a number, we can do this:
rates.forEach((rate) => { rate.addEventListener("click", () =>{ rating.innerHTML =rate.innerHTML submitButton.addEventListener("click", () =>{ thanksContainer.classList.remove("hidden") mainContainer.style.display="none" }) }) })
The remainder is excellent.
I hope it's useful. 👍
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord