Interactive rating component

Community feedback

• 

  バレンタイン 😈•64,190

  @VCaramesPosted almost 2 years ago

  Hey there! 👋 Here are some suggestions to help improve your code:

  • The “icons/images” in this component serve no other purpose then to be decorative; They add no value. There Alt Tag should be left blank and have an aria-hidden=“true” to hide them from assistive technology.

  More Info:📚

  https://www.w3.org/WAI/tutorials/images/

  • The proper way to build this challenge is to create a form and inside of it, the “rating buttons” should be built using an input radio (wrap all of them inside a fieldset), since this will prevent additional buttons from being active at the same time, and it should have a label element attached to it for accessibility.

  More Info:📚

  MDN <input type="radio">

  MDN <fieldset>: The Field Set element

  • Currently, users can submit without selecting a rating. To fix this, you can do one of the following:

  1. Make the “5” rating the default rating.
  2. Create an error message, telling users they need make a section.
  3. Disable the button until a selection is made.

  If you have any questions or need further clarification, feel free to reach out to me.

  Happy Coding! 🍂🦃

  Marked as helpful

  2
• 

  Sean Gray•690

  @seangray-devPosted almost 2 years ago

  Looks good! One small suggestion is to increase the line-height on your paragraph text. It can be difficult to read if the text is too bunched up together, and can cause eye strain. To give it some more breathing room you can try something like this:

  line-height: 1.5; 
  

  I hope this helps! Keep it up! 😁😁

  Marked as helpful

  1