Submitted almost 2 years ago
Git & Gitflow, HTML&CSS, Flexbox and Javascript
@Have-Samuel
Design comparison
SolutionDesign
Solution retrospective
Hello Devs, I hope y'all are well, Enjoy your holiday and have a Happy New Year. As usual Comments, Suggestions, and ideas are welcome.
Thanks Have Samuel
Community feedback
- @Osama-ElshimyPosted almost 2 years ago
Nice work.
Here are some points you can improve:
-
You should change the background color of the selected rate.
-
You can add animation on the
input
andbutton
elements like this:
.number, .button { transition: all 0.5s; }
Read more about
transitions
here https://www.w3schools.com/css/css3_transitions.asp- I can actually go submit the form without choosing a rate. This is a problem. The user shouldn't be able to proceed unless they choose a rating.
You can fix it like this:
// Insdie the submitHandler function. Add the following line right after the loob if (!selectedValue) { return; // If the user doesn't select a rate }
Overall, that was a nice job. I hope you find this helpful.
Happy Coding!
Marked as helpful0 -
- @Have-SamuelPosted almost 2 years ago
Hello Osama,
Thanks, This is really good.
0@Osama-ElshimyPosted almost 2 years ago@Have-Samuel
You're very welcome my friend :)
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord