Interactive Rating Componen, using SASS, vanilla JS, animation
Design comparison
Solution retrospective
Hi guys,
Hoping to hear some feedback and what I can improve. Thank you!
Happy Coding :)
Community feedback
- @RioCantrePosted over 2 years ago
Hello there! Awesome work with this challenge. Looking at your solution, I think you should know the following as well…
- The HTML structure is well organized and readable
- Proper usage of semantic tags
- Well done in using Sass for styling with proper compositions and sizing elements
- The project is responsive and utilized the details based on the original design
- The hover and active state of the button and numbers is done properly
- Awesome work in adding animation for the numbers and button
- The JS functionality is working well, it generate selected number upon the click event
Question: How come there are three big
script
tag content , is it part of the animation on the project?Above all, the project is well implemented. Keep up the good work!
0@DanK1368Posted over 2 years ago@RioCantre Thanks for the feedback. That definitely motivates me to push harder. The only issue, I just realized is that if the user doesnt choose any rating the form can still be submitted. It should only get submitted if the user chooses a rating. Whats the best way to solve that? And yes, the big script tags are part of the animation. I'm wondering if there are performance issues when putting script tags like this?
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord