Submitted over 2 years ago
Interactive Rating Challenge (HTML, CSS, JavaScript)
@JoeDeSantis1
Design comparison
SolutionDesign
Solution retrospective
I'm looking for feedback on if my code looks clean. Also, if there are any ways that I can be more concise. I don't think I missed anything but if I did please let me know. Thanks!
Community feedback
- @alosoftPosted over 2 years ago
@JoeDeSantis1 There is a couple of things you need to do
- You need to remove the border from the submit button
button{ border: none; }
To fiix your Semantic HTML errors
- change the root element from div to main tag
- change the "how did we do" tag to H1
- the heading tag need to be H2
I also noticed that when no rating is selected the Thank You screen does not show the selected rating comment. I would be nice if a user is required to select at least one rating
Nice work!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord