Design comparison
Solution retrospective
Feel free to check work.
Community feedback
- @itadori-kunPosted about 2 years ago
Hello @anoopkundu567, Congratulations on completing the challenge, it's awesome but I do have a few suggestions.
-
You should write a code to validate that the submit button will only go through when the ratings have been clicked so it does not give you the '[object HTMLSpanElement]' but the value.
-
The hover effects on the ratings <span> should have the color (var(--orange)) when hovered on and the active state color (var(--light-grey)).
-
It would do well to add a font size to your submitted text.
-
Try using more Semantic UI. Check out: https://www.w3schools.com/html/html5_semantic_elements.asp for how this can be done or what each tag does to reduce the many uses of "DIVs" in your code.
-
Try using less of the !important keyword except extremely necessary.
Good luck and Happy Coding Itadori-kun
Marked as helpful0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord