Interactive rating card

Community feedback

• 

  romila•3,570

  @romila2003Posted about 2 years ago

  Hi Ojoachele,

  Congratulations 🎉 for completing this challenge, it was a great attempt however there are some issues regarding your HTML and CSS:

  1. It is best great that you used the footer tag for the footer however it is best practice to wrap your code within the main tag which would ensure that your content is wrapped within the correct landmarks e.g. <main class="container"></main>
  2. You should give the buttons, the cursor property of pointer e.g. cursor: pointer;
  3. Since this project does not revolve heavily around responsiveness and changing the layout as you increase the screen size, it is not necessary to add a media query. Therefore, instead of giving your card a width of 70% in mobile screen, you can write 100% instead and remove the margin property within the media queries too since the card is already centred in the middle.
  4. Also, I would encourage you to set the max-width property to 400px and then give your body a padding of 0 20px so that the card does not touch the side.

  Overall, great attempt and wish you the best for your future projects so keep coding 👍.

  1

  ---

  

  Ojoachele Onuh•50

  @AchelePosted about 2 years ago

  @romila2003 Thank you so much

  1