interactive rating

Community feedback

• 

  バレンタイン 😈•64,190

  @VCaramesPosted almost 2 years ago

  Hey there! 👋 Here are some suggestions to help improve your code:

  • The “icons/images” in this component serve no other purpose then to be decorative; They add no value. There Alt Tag should be left blank and have an aria-hidden=“true” to hide them from assistive technology.

  More Info:📚

  https://www.w3.org/WAI/tutorials/images/

  • Your ratings should have an active state to let users know which rating they have chosen.

  • Add a cursor: pointer to the rating buttons to improve users experience.

  • The proper way to build this challenge is to create a form and inside of it, the “rating buttons” should be built using an input radio (wrap all of them inside a fieldset), since this will prevent additional buttons from being active at the same time, and it should have a label element attached to it for accessibility.

  More Info:📚

  MDN <input type="radio">

  MDN <fieldset>: The Field Set element

  • Currently, users can submit without selecting a rating. To fix this, you can do one of the following:

  1. Make the “5” rating the default rating.
  2. Create an error message, telling users they need make a section.
  3. Disable the button until a selection is made.

  If you have any questions or need further clarification, feel free to reach out to me.

  Happy Coding! 🍂🦃

  Marked as helpful

  0
• 

  MOHAMMED AMINE BELFKIH•230

  @TheXilotPosted almost 2 years ago

  Hello, I like your job, however d'ont forget to add cursor-pointer class to buttons and links, also in small screen give your card a width of 70% or plus of your screen width . best regards,

  Marked as helpful

  0
• 

  Marcus Rangel•460

  @WebDevCamposPosted almost 2 years ago

  Hi there! If I may, there's an observation I would like to make. Firstly, the component needs adjustment in it's responsivity, because it's stretching a lot haha. In my phone, for instance, it's width barely reach 200px. Secondly, you could wrap your index.html code in a main tag, for the sake of accessibility. And finally, the link provided for your code solution leads to the qr component solution, not this. I hope I could be helpful. Please, fell free to reach me out! Kind regards!

  Marked as helpful

  0