Design comparison
Solution retrospective
I feel like I have a lot of css attributes being altered. I've done tutorials where they were able to do very similar layouts, but they have what seems to be 25% of the code in their css than I do. Do I just have a lot of redundant code? What could I do to clean it up a bit?
Community feedback
- @andreich1980Posted over 2 years ago
Hi there.
Your live website not live at all, it's dead :(
And about your code: it looks alright to me.
But the submit button should be a button, not just span. And same for ratings: they should be either buttons (since user can click on it) or labels for hidden checkboxes.
And I think you missed media queries.
Cheers.
Marked as helpful1@thegreatgigPosted over 2 years ago@andreich1980 thank you for your feedback. I will change them to buttons, and get the site working.
I’m not sure what you mean about missing media queries though. Could you explain further?
1@andreich1980Posted over 2 years ago@thegreatgig Media queries is the way CSS can make things "responsive" - look differently depending on screen size (phone, tablet, laptop, wide monitor) or device type (screen, screen-reader, printer). You can tell CSS: I want this block (rating component card) take the whole width on mobile, but on wider screens (i.e. starting from 480px) it should not be wider than 300px and should be centered horizontally. Or "this H1 should have font size 16 on mobile and 18 on laptop".
Marked as helpful0@thegreatgigPosted over 2 years ago@andreich1980
Ohhh gotcha! Ya, definitely forgot to do those! Will try to make that happen. Thanks for the clarification!
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord